[Mesa-dev] [PATCH 14/59] i965: add support for disassembling DF immediates

[Connor Abbott]

On Sun, May 1, 2016 at 5:36 PM, Jordan Justen <jordan.l.justen at intel.com> wrote:
> On 2016-04-29 04:29:11, Samuel Iglesias Gonsálvez wrote:
>> From: Connor Abbott <connor.w.abbott at intel.com>
>>
>> ---
>>  src/mesa/drivers/dri/i965/brw_disasm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c b/src/mesa/drivers/dri/i965/brw_disasm.c
>> index c4e3761..d9e531b 100644
>> --- a/src/mesa/drivers/dri/i965/brw_disasm.c
>> +++ b/src/mesa/drivers/dri/i965/brw_disasm.c
>> @@ -1107,7 +1107,7 @@ imm(FILE *file, const struct brw_device_info *devinfo, unsigned type, brw_inst *
>>        format(file, "%-gF", brw_inst_imm_f(devinfo, inst));
>>        break;
>>     case GEN8_HW_REG_IMM_TYPE_DF:
>> -      string(file, "Double IMM");
>> +      format(file, "%-gDF", brw_inst_imm_df(devinfo, inst));
>
> Should we use the 'L' suffix instead of 'DF' to follow C? Or 'LF to
> follow GLSL?

Given that this is the disassembler, I think it makes the most sense
to follow the PRM's notation rather than C's or GLSL's. Also, all the
other types follow the PRM so changing it just for doubles would be
inconsistent.

>
> -Jordan
>
>>        break;
>>     case GEN8_HW_REG_IMM_TYPE_HF:
>>        string(file, "Half Float IMM");
>> --
>> 2.5.0
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev