[Mesa-dev] [PATCH 14/59] i965: add support for disassembling DF immediates

Matt Turner mattst88 at gmail.com
Sun May 1 23:05:22 UTC 2016


On Sun, May 1, 2016 at 2:36 PM, Jordan Justen <jordan.l.justen at intel.com> wrote:
> On 2016-04-29 04:29:11, Samuel Iglesias Gonsálvez wrote:
>> From: Connor Abbott <connor.w.abbott at intel.com>
>>
>> ---
>>  src/mesa/drivers/dri/i965/brw_disasm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c b/src/mesa/drivers/dri/i965/brw_disasm.c
>> index c4e3761..d9e531b 100644
>> --- a/src/mesa/drivers/dri/i965/brw_disasm.c
>> +++ b/src/mesa/drivers/dri/i965/brw_disasm.c
>> @@ -1107,7 +1107,7 @@ imm(FILE *file, const struct brw_device_info *devinfo, unsigned type, brw_inst *
>>        format(file, "%-gF", brw_inst_imm_f(devinfo, inst));
>>        break;
>>     case GEN8_HW_REG_IMM_TYPE_DF:
>> -      string(file, "Double IMM");
>> +      format(file, "%-gDF", brw_inst_imm_df(devinfo, inst));
>
> Should we use the 'L' suffix instead of 'DF' to follow C? Or 'LF to
> follow GLSL?

No, we definitely want to print the hardware type ("DF").


More information about the mesa-dev mailing list