[Mesa-dev] [PATCH 3/3] nir/opt_algebraic: lower mod() with doubles operands if lower_fmod64 is enabled

[Samuel Iglesias Gonsálvez]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256



On 29/04/16 20:26, Jordan Justen wrote:
> On 2016-04-28 04:19:18, Samuel Iglesias Gonsálvez wrote:
>> Make this distintion as the drivers might need to lower it inside NIR
.
>>
>> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
>> ---
>>  src/compiler/nir/nir.h                | 2 ++
>>  src/compiler/nir/nir_opt_algebraic.py | 3 ++-
>>  2 files changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h
>> index a478124..83a8cae 100644
>> --- a/src/compiler/nir/nir.h
>> +++ b/src/compiler/nir/nir.h
>> @@ -1631,6 +1631,8 @@ typedef struct nir_shader_compiler_options {
>>     bool lower_fsat;
>>     bool lower_fsqrt;
>>     bool lower_fmod32;
>> +   /** Lowers fmod when it does not support doubles */
> 
> This comment seems out of place compared to the other options here.
> Maybe it is not necessary?
> 

Yeah, I wanted to make it explicit but it is not necessary. I am going
to get rid of it.

> Series Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

Thanks,

Sam

> 
>> +   bool lower_fmod64;
>>     bool lower_bitfield_extract;
>>     bool lower_bitfield_insert;
>>     bool lower_uadd_carry;
>> diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir
/nir_opt_algebraic.py
>> index afe653e..f81416b 100644
>> --- a/src/compiler/nir/nir_opt_algebraic.py
>> +++ b/src/compiler/nir/nir_opt_algebraic.py
>> @@ -296,7 +296,8 @@ optimizations = [
>>     (('iadd', '#a', ('iadd', b, '#c')), ('iadd', ('iadd', a, c), b)),
>>  
>>     # Misc. lowering
>> -   (('fmod', a, b), ('fsub', a, ('fmul', b, ('ffloor', ('fdiv', a, b
)))), 'options->lower_fmod32'),
>> +   (('fmod at 32', a, b), ('fsub', a, ('fmul', b, ('ffloor', ('fdiv', a
, b)))), 'options->lower_fmod32'),
>> +   (('fmod at 64', a, b), ('fsub', a, ('fmul', b, ('ffloor', ('fdiv', a
, b)))), 'options->lower_fmod64'),
>>     (('frem', a, b), ('fsub', a, ('fmul', b, ('ftrunc', ('fdiv', a, b
)))), 'options->lower_fmod32'),
>>     (('uadd_carry at 32', a, b), ('b2i', ('ult', ('iadd', a, b), a)), 'o
ptions->lower_uadd_carry'),
>>     (('usub_borrow at 32', a, b), ('b2i', ('ult', a, b)), 'options->lowe
r_usub_borrow'),
>> -- 
>> 2.5.0
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXKDU2AAoJEH/0ujLxfcNDk3sP/jcdtoewGcmSYE6gONaL6jGf
MgTraowhvgCFy/pat3EuczcbwpRA/L2c8YnFfWbFm0Nw7eV4N46K8nFxs/DNbSCR
vFiOXaDb5/iK175LhDOUIdxY3UG80JlTX006xR8Xb7wPwsJS2MB5Jh+M07wToGo0
FQkaa93yM8f9xwfEpbX4L6jHA4NJzrFmFUl5tXdoIod2J4k/kjdVxHkEa8FCJxQn
G/5xwB20RPNyZg6HZKmPTySCGbTsGQeJrc4lqueU5Kzk59plfRwFt1SWeFnzPL+5
tQ1pARCQhjdNw5WnlQkd6gZv2YDkJPPu2BazDo4UW4sCj2K8KDs55KFEzv3fL46G
cSGn6x4mjzOalSwtIHguzzxsn0+NX/hV4PniEqx5on1tbC+oovRVdENQlK6z0px+
eMK9sRj02Js+MRjGu3YpKOwT3IXq8fcI1JB6FaPIlCnr6dCjh5WQJKzNQS/nEa7p
856amLuFOcXjV3OrOBg5188b7rqQ16ZfaZ9kZh6Mn0QitHEz+YOFGzxag5/MBcOv
OuRraQHoOb92F1XhGx6l8bsN92o3/hau5kVscSH8esn0apR1kz+PZzblt987bVSG
qcpIAaogAi11LSmnE0RuxYQJ2QOZQK3mALTXtzxZJilVEnRMXLj7dBoPtsxyJf2K
eObiiw/3F8yJ5X0EW4NF
=aR43
-----END PGP SIGNATURE-----