[Mesa-dev] [PATCH 2/3] mesa: rename lower_fmod to lower_fmod32

[Samuel Iglesias Gonsálvez]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256



On 29/04/16 20:43, Jason Ekstrand wrote:
> Why not just squash 2 and 3 and call it "Separate 32 and 64-bit
> fmod lowering" or something like that.
> 

OK, I like it.

Sam

> 
> On Thu, Apr 28, 2016 at 4:19 AM, Samuel Iglesias Gonsálvez < 
> siglesias at igalia.com> wrote:
> 
>> A later patch will add lower_fmod64 option to NIR.
>> 
>> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com> 
>> --- src/compiler/nir/nir.h                   | 2 +- 
>> src/compiler/nir/nir_opt_algebraic.py    | 4 ++-- 
>> src/mesa/drivers/dri/i965/brw_compiler.c | 2 +- 3 files changed,
>> 4 insertions(+), 4 deletions(-)
>> 
>> diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h 
>> index 2e89bc5..a478124 100644 --- a/src/compiler/nir/nir.h +++
>> b/src/compiler/nir/nir.h @@ -1630,7 +1630,7 @@ typedef struct
>> nir_shader_compiler_options { bool lower_fpow; bool lower_fsat; 
>> bool lower_fsqrt; -   bool lower_fmod; +   bool lower_fmod32; 
>> bool lower_bitfield_extract; bool lower_bitfield_insert; bool
>> lower_uadd_carry; diff --git
>> a/src/compiler/nir/nir_opt_algebraic.py 
>> b/src/compiler/nir/nir_opt_algebraic.py index 60ee170..afe653e
>> 100644 --- a/src/compiler/nir/nir_opt_algebraic.py +++
>> b/src/compiler/nir/nir_opt_algebraic.py @@ -296,8 +296,8 @@
>> optimizations = [ (('iadd', '#a', ('iadd', b, '#c')), ('iadd',
>> ('iadd', a, c), b)),
>> 
>> # Misc. lowering -   (('fmod', a, b), ('fsub', a, ('fmul', b,
>> ('ffloor', ('fdiv', a, b)))), 'options->lower_fmod'), -
>> (('frem', a, b), ('fsub', a, ('fmul', b, ('ftrunc', ('fdiv', a,
>> b)))), 'options->lower_fmod'), +   (('fmod', a, b), ('fsub', a,
>> ('fmul', b, ('ffloor', ('fdiv', a, b)))), 
>> 'options->lower_fmod32'), +   (('frem', a, b), ('fsub', a,
>> ('fmul', b, ('ftrunc', ('fdiv', a, b)))), 
>> 'options->lower_fmod32'), (('uadd_carry at 32', a, b), ('b2i',
>> ('ult', ('iadd', a, b), a)), 'options->lower_uadd_carry'), 
>> (('usub_borrow at 32', a, b), ('b2i', ('ult', a, b)), 
>> 'options->lower_usub_borrow'),
>> 
>> diff --git a/src/mesa/drivers/dri/i965/brw_compiler.c 
>> b/src/mesa/drivers/dri/i965/brw_compiler.c index c8a38e3..5ff1a61
>> 100644 --- a/src/mesa/drivers/dri/i965/brw_compiler.c +++
>> b/src/mesa/drivers/dri/i965/brw_compiler.c @@ -76,7 +76,7 @@
>> shader_perf_log_mesa(void *data, const char *fmt, ...) .lower_sub
>> = true, \ .lower_fdiv = true, \ .lower_scmp = true, \ -
>> .lower_fmod = true, \ +   .lower_fmod32 = true, \ 
>> .lower_bitfield_extract = true, \ .lower_bitfield_insert = true, 
>> \ .lower_uadd_carry = true, \ -- 2.5.0
>> 
>> _______________________________________________ mesa-dev mailing
>> list mesa-dev at lists.freedesktop.org 
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>> 
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXKDTFAAoJEH/0ujLxfcNDn9gP/jpIW25kaJ3xHsfEhZBb5hKt
0rrgF9U1Olij2zyg9/Ltf9Dd8ofbaj2HqcMnOgjDF83zNPdw6hvAUsG0veoqAfFk
4e9ln/wndwLRyh7vQ18lcK63uCZTIpwJ1Uos5MKuV88Tyqc+FYocMNYuUh6B00vm
VMevtziYFR/8tDZrtay/r8PdaD3v7yTotEci1lBm3sJ/yTZCzulWVCknTInN+3AY
Z5/V8H6PVkPDxZCGB0k0sHEtLjB2voNmRgxB0RoDuLiOmz3T7THtj/GPc653tHm1
DfJB4SJqAFmkbj2kNlfqCzu2v/Le+zGWWJi4SMHAV2nK3V5V+/pbiQN2GYbCB/rf
5ZWiQ5LnIBxruNmPAIzij+k5DOemrRxqfWNY+obsRi3K48cIo4XTS9vHwS7lRGZz
ZzTNCWCk0hhO4X9iJTME/cEQh0vn4I71rOVo2puU+bFSSXTfIBlk5lkleXwjWoEg
xjw33f1ZgOq08rAbNMGbjhYfsS5HEenkR6eDZtNSHHihFgvzk0EC4JTAveElbDWY
XICa13q99XUPY7OjN6WdmZuUw2zTYs6Q8hYaVX2SQWK8llIxHLDBG5LX3KgCTIdu
519QG9enXw+dzQOCpzW045Uy+ApEckT01hUgSEtnvBV0E+xSAKXH9bUANSi14K1g
Zw4PNkmLbfJBz5ueO1XZ
=FXD9
-----END PGP SIGNATURE-----