[Mesa-dev] [PATCH] radeonsi: set DECOMPRESS_Z_ON_FLUSH if nr_samples >= 4

Nicolai Hähnle nhaehnle at gmail.com
Thu May 5 16:47:38 UTC 2016


Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

On 04.05.2016 17:35, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>
> Vulkan always sets this. It only affects in-place Z decompression.
> This is recommended for performance, but what app uses MSAA depth
> texturing?
> ---
>   src/gallium/drivers/radeonsi/si_state.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c
> index 81a4341..c6e10b7 100644
> --- a/src/gallium/drivers/radeonsi/si_state.c
> +++ b/src/gallium/drivers/radeonsi/si_state.c
> @@ -1104,7 +1104,8 @@ static void si_emit_db_render_state(struct si_context *sctx, struct r600_atom *s
>   	/* DB_RENDER_OVERRIDE2 */
>   	radeon_set_context_reg(cs, R_028010_DB_RENDER_OVERRIDE2,
>   		S_028010_DISABLE_ZMASK_EXPCLEAR_OPTIMIZATION(sctx->db_depth_disable_expclear) |
> -		S_028010_DISABLE_SMEM_EXPCLEAR_OPTIMIZATION(sctx->db_stencil_disable_expclear));
> +		S_028010_DISABLE_SMEM_EXPCLEAR_OPTIMIZATION(sctx->db_stencil_disable_expclear) |
> +		S_028010_DECOMPRESS_Z_ON_FLUSH(sctx->framebuffer.nr_samples >= 4));
>
>   	db_shader_control = S_02880C_ALPHA_TO_MASK_DISABLE(sctx->framebuffer.cb0_is_integer) |
>   		            sctx->ps_db_shader_control;
>


More information about the mesa-dev mailing list