[Mesa-dev] [PATCH] mesa/compute: Fix indirect dispatch buffer size check on 32-bit systems

Jordan Justen jordan.l.justen at intel.com
Fri May 6 00:38:35 UTC 2016

2655265fcba9017e793026c76e490e04db088c8f, but for compute.

Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
Cc: Kenneth Graunke <kenneth at whitecape.org>

 I don't know if there is a test that this fixes, but it seems like we
 should handle it the same as the draw case.

 Note that the draw indirect param is a pointer, whereas it is a
 GLintptr for dispatch indirect.

 src/mesa/main/api_validate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c
index 6ec65e5..9d29f8d 100644
--- a/src/mesa/main/api_validate.c
+++ b/src/mesa/main/api_validate.c
@@ -1107,7 +1107,7 @@ valid_dispatch_indirect(struct gl_context *ctx,
                         GLintptr indirect,
                         GLsizei size, const char *name)
-   GLintptr end = indirect + size;
+   const uint64_t end = (uint64_t) indirect + size;
    if (!check_valid_to_compute(ctx, name))
       return GL_FALSE;

More information about the mesa-dev mailing list