[Mesa-dev] [PATCH 07/18] winsys/amdgpu: simplify interface of amdgpu_get_new_ib

[Nicolai Hähnle]

From: Nicolai Hähnle <nicolai.haehnle at amd.com>

We'll want to have an amdgpu_cs pointer for future changes.
---
 src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 26 +++++++++++++-------------
 src/gallium/winsys/amdgpu/drm/amdgpu_cs.h |  2 +-
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
index acae6cd..1faa5e0 100644
--- a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
+++ b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
@@ -225,25 +225,30 @@ static bool amdgpu_cs_has_user_fence(struct amdgpu_cs_context *cs)
    return cs->request.ip_type != AMDGPU_HW_IP_UVD && cs->request.ip_type != AMDGPU_HW_IP_VCE;
 }
 
-static bool amdgpu_get_new_ib(struct radeon_winsys *ws, struct amdgpu_ib *ib,
-                              struct amdgpu_cs_ib_info *info, unsigned ib_type)
+static bool amdgpu_get_new_ib(struct radeon_winsys *ws, struct amdgpu_cs *cs,
+                              enum ib_type ib_type)
 {
    /* Small IBs are better than big IBs, because the GPU goes idle quicker
     * and there is less waiting for buffers and fences. Proof:
     *   http://www.phoronix.com/scan.php?page=article&item=mesa-111-si&num=1
     */
+   struct amdgpu_ib *ib = NULL;
+   struct amdgpu_cs_ib_info *info = &cs->csc->ib[ib_type];
    unsigned buffer_size, ib_size;
 
    switch (ib_type) {
    case IB_CONST_PREAMBLE:
+      ib = &cs->const_preamble_ib;
       buffer_size = 4 * 1024 * 4;
       ib_size = 1024 * 4;
       break;
    case IB_CONST:
+      ib = &cs->const_ib;
       buffer_size = 512 * 1024 * 4;
       ib_size = 128 * 1024 * 4;
       break;
    case IB_MAIN:
+      ib = &cs->main;
       buffer_size = 128 * 1024 * 4;
       ib_size = 20 * 1024 * 4;
       break;
@@ -414,8 +419,7 @@ amdgpu_cs_create(struct radeon_winsys_ctx *rwctx,
    cs->csc = &cs->csc1;
    cs->cst = &cs->csc2;
 
-   if (!amdgpu_get_new_ib(&ctx->ws->base, &cs->main, &cs->csc->ib[IB_MAIN],
-                          IB_MAIN)) {
+   if (!amdgpu_get_new_ib(&ctx->ws->base, cs, IB_MAIN)) {
       amdgpu_destroy_cs_context(&cs->csc2);
       amdgpu_destroy_cs_context(&cs->csc1);
       FREE(cs);
@@ -436,8 +440,7 @@ amdgpu_cs_add_const_ib(struct radeon_winsys_cs *rcs)
    if (cs->ring_type != RING_GFX || cs->const_ib.ib_mapped)
       return NULL;
 
-   if (!amdgpu_get_new_ib(&ws->base, &cs->const_ib, &cs->csc->ib[IB_CONST],
-                          IB_CONST))
+   if (!amdgpu_get_new_ib(&ws->base, cs, IB_CONST))
       return NULL;
 
    cs->csc->request.number_of_ibs = 2;
@@ -461,8 +464,7 @@ amdgpu_cs_add_const_preamble_ib(struct radeon_winsys_cs *rcs)
        cs->const_preamble_ib.ib_mapped)
       return NULL;
 
-   if (!amdgpu_get_new_ib(&ws->base, &cs->const_preamble_ib,
-                          &cs->csc->ib[IB_CONST_PREAMBLE], IB_CONST_PREAMBLE))
+   if (!amdgpu_get_new_ib(&ws->base, cs, IB_CONST_PREAMBLE))
       return NULL;
 
    cs->csc->request.number_of_ibs = 3;
@@ -884,13 +886,11 @@ static void amdgpu_cs_flush(struct radeon_winsys_cs *rcs,
       amdgpu_cs_context_cleanup(cs->csc);
    }
 
-   amdgpu_get_new_ib(&ws->base, &cs->main, &cs->csc->ib[IB_MAIN], IB_MAIN);
+   amdgpu_get_new_ib(&ws->base, cs, IB_MAIN);
    if (cs->const_ib.ib_mapped)
-      amdgpu_get_new_ib(&ws->base, &cs->const_ib, &cs->csc->ib[IB_CONST],
-                        IB_CONST);
+      amdgpu_get_new_ib(&ws->base, cs, IB_CONST);
    if (cs->const_preamble_ib.ib_mapped)
-      amdgpu_get_new_ib(&ws->base, &cs->const_preamble_ib,
-                        &cs->csc->ib[IB_CONST_PREAMBLE], IB_CONST_PREAMBLE);
+      amdgpu_get_new_ib(&ws->base, cs, IB_CONST_PREAMBLE);
 
    ws->num_cs_flushes++;
 }
diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.h b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.h
index 1caec0a..69e5995 100644
--- a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.h
+++ b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.h
@@ -59,7 +59,7 @@ struct amdgpu_ib {
    unsigned                used_ib_space;
 };
 
-enum {
+enum ib_type {
    IB_CONST_PREAMBLE = 0,
    IB_CONST = 1, /* the const IB must be first */
    IB_MAIN = 2,
-- 
2.7.4