[Mesa-dev] [PATCH 1/2] i965: Enable ES 3.2 sample shading extensions.

[Ilia Mirkin]

I think it's more than 8... for example, these 6 fail for me as well:

dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_sample.negative.interpolate_struct_member,Fail
dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_sample.negative.interpolate_constant,Fail
dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_centroid.negative.interpolate_struct_member,Fail
dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_centroid.negative.interpolate_constant,Fail
dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_offset.negative.interpolate_struct_member,Fail
dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_offset.negative.interpolate_constant,Fail

However I don't think it's such a huge deal. (We end up successfully
compiling a shader we shouldn't.)

On Thu, May 12, 2016 at 9:31 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> This enables:
> - GL_OES_sample_shading
> - GL_OES_sample_variables
> - GL_OES_shader_multisample_interpolation
>
> We pass all the CTS tests, and all but 8 of the dEQP-GLES31 tests.
> Half of the failing dEQP tests appear to be broken tests; the other
> four still need investigating but cover an obscure corner case.
>
> Otherwise, the functionality is in great shape, and actually in better
> shape than the ARB_sample_shading support we've shipped for years
> (we fixed a number of bugs when enabling this).  So it makes sense to
> enable it for our users in the Mesa 12.0 release.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c
> index 8d98788..7f44c1d 100644
> --- a/src/mesa/drivers/dri/i965/intel_extensions.c
> +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
> @@ -308,6 +308,7 @@ intelInitExtensions(struct gl_context *ctx)
>        ctx->Extensions.EXT_framebuffer_multisample_blit_scaled = true;
>        ctx->Extensions.EXT_transform_feedback = true;
>        ctx->Extensions.OES_depth_texture_cube_map = true;
> +      ctx->Extensions.OES_sample_variables = true;
>
>        ctx->Extensions.ARB_timer_query = brw->intelScreen->hw_has_timestamp;
>
> --
> 2.8.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev