[Mesa-dev] [PATCH 29/28] i965/blorp: Get rid of the blorp_prog_data_int() helper

Jason Ekstrand jason at jlekstrand.net
Fri May 13 07:27:01 UTC 2016


On Fri, May 13, 2016 at 12:07 AM, Pohjolainen, Topi <
topi.pohjolainen at intel.com> wrote:

> On Wed, May 11, 2016 at 11:37:10AM -0700, Jason Ekstrand wrote:
> > The helper was initially created to allow us to set reasonable defaults
> as
> > we mutated the brw_blorp_prog_data structure in preparation for NIR.  Now
> > that everything is going through brw_blorp_compile_nir_shader() which
> fully
> > fills out the brw_blorp_prog_data structure, we don't need the helper.
> > ---
> >  src/mesa/drivers/dri/i965/brw_blorp.c         | 16 ----------------
> >  src/mesa/drivers/dri/i965/brw_blorp.h         |  2 --
> >  src/mesa/drivers/dri/i965/brw_blorp_blit.cpp  |  8 ++------
> >  src/mesa/drivers/dri/i965/brw_blorp_clear.cpp |  2 --
> >  4 files changed, 2 insertions(+), 26 deletions(-)
>
> Could this be squashed into patch 17?
>

No.  It existed precicely to keep the old blorp code working while we added
fields needed for NIR shaders.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160513/3af4feb4/attachment.html>


More information about the mesa-dev mailing list