[Mesa-dev] [PATCH 00/14] st/mesa: accelerate glReadPixels PBO downloads

[Brian Paul]

On 05/18/2016 09:25 AM, Nicolai Hähnle wrote:
> Hi,
>
> this series makes the existing PBO texture upload code symmetric, adding a
> download path that uses shader images a no-attachment framebuffers. This
> should help performance by reducing stalls in several games, including
> GRID: Autosport (verified with an apitrace), Metro 2033 Redux, and likely
> others.
>
> It should be possible to extend the framework to glGetTexImage without much
> effort, but I wanted to get out what I have so far. Tested with Piglit on
> radeonsi, including some more extensive local tests that I have yet to clean
> up.
>
> Please review!

I did a quick scan of the patches and it looks pretty good at the high 
level.  I don't know if you want to wait for someone to do a detailed 
review.

Reviewed-by: Brian Paul <brianp at vmware.com>