[Mesa-dev] [PATCH 03/11] i965: Use nir to lower cs-derived variables
kenneth at whitecape.org
Thu May 26 04:43:01 UTC 2016
On Tuesday, May 24, 2016 1:37:48 AM PDT Jordan Justen wrote:
> We added this support into nir for Mesa's Intel vulkan driver as part
> of the SPIR-V support, so we can use it for the i965 driver as well.
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> src/mesa/drivers/dri/i965/brw_compiler.c | 2 --
> 1 file changed, 2 deletions(-)
> diff --git a/src/mesa/drivers/dri/i965/brw_compiler.c b/src/mesa/drivers/dri/i965/brw_compiler.c
> index c3a192d..82131db 100644
> --- a/src/mesa/drivers/dri/i965/brw_compiler.c
> +++ b/src/mesa/drivers/dri/i965/brw_compiler.c
> @@ -199,8 +199,6 @@ brw_compiler_create(void *mem_ctx, const struct brw_device_info *devinfo)
> .LowerShaderSharedVariables = true;
> - compiler->glsl_compiler_options[MESA_SHADER_COMPUTE]
> - .LowerCsDerivedVariables = true;
> return compiler;
I did a double-take when I saw you were turning off the GLSL IR lowering
a patch before adding new NIR-based lowering. Seemed wrong. But here
you're switching to different existing NIR lowering.
Perhaps add this to your commit message:
nir_lower_system_values() can do this for us.
We added this support into ...
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: This is a digitally signed message part.
More information about the mesa-dev