[Mesa-dev] [PATCH v2 01/13] glsl: Add glsl LowerCsDerivedVariables option

[Jordan Justen]

On 2016-05-27 13:18:54, Jason Ekstrand wrote:
>    On Fri, May 27, 2016 at 11:24 AM, Jordan Justen
>    <jordan.l.justen at intel.com> wrote:
> 
>      diff --git a/src/mesa/state_tracker/st_extensions.c
>      b/src/mesa/state_tracker/st_extensions.c
>      index 68e6601..8f249bb 100644
>      --- a/src/mesa/state_tracker/st_extensions.c
>      +++ b/src/mesa/state_tracker/st_extensions.c
>      @@ -309,11 +309,13 @@ void st_init_limits(struct pipe_screen *screen,
>             options->LowerCombinedClipCullDistance = true;
>             options->LowerBufferInterfaceBlocks = true;
> 
>      -      if (sh == PIPE_SHADER_COMPUTE)
>      +      if (sh == PIPE_SHADER_COMPUTE) {
>                options->LowerShaderSharedVariables = true;
>      +      }
>          }
> 
>          c->LowerTessLevel = true;
>      +   c->LowerCsDerivedVariables = true;
> 
>    This looks a bit odd.  Did you initially put this in the condition above? 
>    (Hence the added braces).  If you really want it here, it's probably best
>    to drop the braces above.
>     

Whoops. Yeah, v1 had LowerCsDerivedVariables in the compiler options.

-Jordan