[Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

[Samuel Iglesias Gonsálvez]

On 31/05/16 02:26, Timothy Arceri wrote:
> On Mon, 2016-05-30 at 15:46 +0200, Samuel Iglesias Gonsálvez wrote:
>>
>> On 27/05/16 08:39, Samuel Iglesias Gonsálvez wrote:
>>>
>>>
>>>
>>> On 26/05/16 09:46, Timothy Arceri wrote:
>>>>
>>>> On Thu, 2016-05-26 at 17:44 +1000, Timothy Arceri wrote:
>>>>>
>>>>> On Thu, 2016-05-26 at 07:56 +0200, Samuel Iglesias Gonsálvez
>>>>> wrote:
>>>>>>
>>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> Timothy found that tests with unpacked double vector input
>>>>>> varyings
>>>>>> were failing in i965 driver. For example, this is happening
>>>>>> when
>>>>>> using explicit locations because Mesa disables varying
>>>>>> packing for
>>>>>> that case.
>>>>>>
>>>>>> These patches fix the following piglit test:
>>>>>>
>>>>>> spec/arb_gpu_shader_fp64/execution/vs-fs-explicit-locations
>>>>>>
>>>>>> Samuel Iglesias Gonsálvez (2):
>>>>>>   i965/fs: fix offset when loading double vector input
>>>>>> varyings
>>>>>>   i965/fs: fix FS_OPCODE_CINTERP for unpacked double input
>>>>>> varyings
>>>>>>
>>>>>>  src/mesa/drivers/dri/i965/brw_fs.cpp     | 13 ++++++++++++-
>>>>>>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22
>>>>>> +++++++++++++++++++++-
>>>>>>  2 files changed, 33 insertions(+), 2 deletions(-)
>>>>>>
>>>>> These are both:
>>>>>
>>>>> Tested-by: Timothy Arceri <timothy.arceri at collabora.com>
>>>>>
>>>>> The logic looks ok to me also, but you probably want someone
>>>>> more familiar with the backend to take a quick look also.
>>>> Forgot to ask. Did you also check the other stages work as
>>>> expected
>>>> with explicit locations?
>>>>
>>> I did not check them. I am going to do it know and send patches if
>>> needed.
>>>
>> I needed to fix Geometry shaders too. I have sent a patch for it.
>>
>> Sam
> 
> Thanks Sam. Can you also send a piglit test since there are no test
> suites that seem to currently test this.
> 

Done:

https://lists.freedesktop.org/archives/piglit/2016-May/019888.html

Sam

> Thanks,
> Tim
> 
>>
>>>
>>> Thanks,
>>>
>>> Sam
>>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160531/ed4bf124/attachment.sig>