[Mesa-dev] [PATCH] nir: Flip gl_SamplePosition in nir_lower_wpos_ytransform().

Kenneth Graunke kenneth at whitecape.org
Tue Nov 1 23:49:21 UTC 2016


On Tuesday, November 1, 2016 2:25:49 PM PDT Francisco Jerez wrote:
> Assuming the hardware is set-up to use a screen coordinate system
> flipped vertically with respect to the GL's window coordinate system,
> the SYSTEM_VALUE_SAMPLE_POS vector will also be flipped vertically
> with respect to the value expected by the GL, so we need to give it
> the same treatment as gl_FragCoord.  Fixes the following CTS tests on
> i965:
> 
>  ES31-CTS.functional.shaders.multisample_interpolation.interpolate_at_offset.at_sample_position.default_framebuffer
>  ES31-CTS.functional.shaders.sample_variables.sample_pos.correctness.default_framebuffer
> 
> when run with any multisample configuration, e.g. rgba8888d24s8ms4.
> 
> Cc: <mesa-stable at lists.freedesktop.org>

Looks good, thanks!

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161101/186b12d3/attachment-0001.sig>


More information about the mesa-dev mailing list