[Mesa-dev] [PATCH 13/59] glsl/ast/ir: Add 64-bit integer constant support

[Ian Romanick]

On 10/27/2016 06:09 AM, Nicolai Hähnle wrote:
> On 26.10.2016 02:59, Ian Romanick wrote:
>> From: Dave Airlie <airlied at redhat.com>
>>
>> This adds support for 64-bit integer constants to the parser,
>> ast and ir.
>>
>> v2: fix a few issues found in testing.
>>
>> v3: Add missing ir_constant copy contructor support.
>>
>> Signed-off-by: Dave Airlie <airlied at redhat.com>
>> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com> [v2]
>> ---
>>  src/compiler/glsl/ast.h                  |   4 ++
>>  src/compiler/glsl/ast_function.cpp       |   9 ++-
>>  src/compiler/glsl/ast_to_hir.cpp         |  14 ++++
>>  src/compiler/glsl/glsl_lexer.ll          |  27 +++++--
>>  src/compiler/glsl/glsl_parser.yy         |  16 +++++
>>  src/compiler/glsl/glsl_parser_extras.cpp |   8 +++
>>  src/compiler/glsl/ir.cpp                 | 117
>> +++++++++++++++++++++++++++++++
>>  src/compiler/glsl/ir.h                   |   6 ++
>>  8 files changed, 193 insertions(+), 8 deletions(-)
>>
> [snip]
>> diff --git a/src/compiler/glsl/glsl_parser_extras.cpp
>> b/src/compiler/glsl/glsl_parser_extras.cpp
>> index a44fedf..6b41c9f 100644
>> --- a/src/compiler/glsl/glsl_parser_extras.cpp
>> +++ b/src/compiler/glsl/glsl_parser_extras.cpp
>> @@ -1242,6 +1242,14 @@ ast_expression::print(void) const
>>        printf("%f ", primary_expression.double_constant);
>>        break;
>>
>> +   case ast_int64_constant:
>> +      printf("%ld ", primary_expression.int64_constant);
>> +      break;
>> +
>> +   case ast_uint64_constant:
>> +      printf("%lu ", primary_expression.uint64_constant);
>> +      break;
> 
> Should this use PRIu64?

Yes.  The previous one should use PRId64.  I'll fix that too.

> Apart from that, this patch is
> 
> Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
> 
> Patch 14 & 15 didn't make it through to me. Is that a gmail problem or a
> mailing list host problem?

They made it to me.  Did you ever receive these?

https://lists.freedesktop.org/archives/mesa-dev/2016-October/133293.html
https://lists.freedesktop.org/archives/mesa-dev/2016-October/133297.html