[Mesa-dev] [PATCH 00/20] anv: Unify pipeline setup across gens

[Kristian Høgsberg]

On Sat, Nov 12, 2016 at 1:35 PM Jason Ekstrand <jason at jlekstrand.net> wrote:

> This series started off as me thinking that we should set the correct
> sampler and binding table entry counts because maybe caching those things
> would improve performance.  Then it turned into spring cleaning.  The end
> result is that gen7_pipeline.c, gen8_pipeline.c, and genX_pipeline_util.h
> are all merged into genX_pipeline.c.  Every single packet in pipeline setup
> now has a common path.
>

This looks great, thanks for finally unifying things the way we always
meant to and getting rid of genX_pipeline_util.h.

For the series:

Reviewed-by: Kristian H. Kristensen <hoegsberg at google.com>


> I still haven't tested the performance of cached sampler states.
>

I'd be interested to hear if you're able to measure anything one way or the
other.

Kristian


>
> Jason Ekstrand (20):
>   anv/pipeline: Set correct binding table and sampler counts
>   anv/pipeline: Get rid of the kernel pointer fields
>   intel/genxml: Make some VS/GS fields consistent across gens
>   anv/pipeline: Stop claiming to support running without a vertex shader
>   anv/pipeline/gen8: Enable VS statistics
>   anv/pipeline: Unify 3DSTATE_VS emission
>   intel/genxml: Make some 3DSTATE_GS fields more consistent
>   anv/pipeline: Unify 3DSTATE_GS emission
>   anv/pipeline: Make emit_3dstate_sbe safe to call without a FS
>   intel/genxml: Make some 3DSTATE_PS fields more consistent
>   anv/pipeline: Unify 3DSTATE_PS emission
>   intel/genxml: Make 3DSTATE_WM more consistent across gens
>   anv/pipeline: Unify 3DSTATE_WM emission
>   anv/pipeline: Move 3DSTATE_PS_EXTRA setup into a helper
>   anv/pipeline: Rework the 3DSTATE_VF_TOPOLOGY helper
>   anv/pipline: Re-order state emission and make it consistent
>   anv/pipeline: Unify graphics_pipeline_create
>   anv/pipeline: Roll genX_pipeline_util.h into genX_pipeline.c
>   anv: Move INTERFACE_DESCRIPTOR_DATA setup to the pipeline
>   anv/pipeline: Use get_scratch_space/address for compute shaders
>
>  src/intel/blorp/blorp_genX_exec.h     |   12 +-
>  src/intel/genxml/gen6.xml             |   32 +-
>  src/intel/genxml/gen7.xml             |   32 +-
>  src/intel/genxml/gen75.xml            |   32 +-
>  src/intel/genxml/gen8.xml             |    8 +-
>  src/intel/genxml/gen9.xml             |    8 +-
>  src/intel/vulkan/Makefile.sources     |    5 -
>  src/intel/vulkan/anv_genX.h           |    7 -
>  src/intel/vulkan/anv_pipeline.c       |   22 -
>  src/intel/vulkan/anv_private.h        |    7 +-
>  src/intel/vulkan/gen7_pipeline.c      |  281 -------
>  src/intel/vulkan/gen8_pipeline.c      |  295 -------
>  src/intel/vulkan/genX_cmd_buffer.c    |   35 +-
>  src/intel/vulkan/genX_pipeline.c      | 1393
> ++++++++++++++++++++++++++++++++-
>  src/intel/vulkan/genX_pipeline_util.h |  959 -----------------------
>  15 files changed, 1471 insertions(+), 1657 deletions(-)
>  delete mode 100644 src/intel/vulkan/gen7_pipeline.c
>  delete mode 100644 src/intel/vulkan/gen8_pipeline.c
>  delete mode 100644 src/intel/vulkan/genX_pipeline_util.h
>
> --
> 2.5.0.400.gff86faf
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161114/90d7cd03/attachment.html>