[Mesa-dev] [PATCH 07/13] glsl: Add comments for the point mode layout-id-qualifier validation

Andres Gomez agomez at igalia.com
Mon Nov 21 16:08:58 UTC 2016


On Thu, 2016-11-17 at 16:47 +1100, Timothy Arceri wrote:
> On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote:
> > The point mode value in an ast_type_qualifier can only be true if the
> > flag is already set since this layout-id-qualifier can only be or not
> > be present in a shader.
> > 
> > Hence, it is useless to check for its value if the flag is already
> > set. However, for coherence and compatibility with future changes we
> > do check its value.
> 
> 
> It's dead code. Please remove the error check and replace it with an
> assert.

I'll send a new version.

-- 
Br,

Andres


More information about the mesa-dev mailing list