[Mesa-dev] [PATCH] docs/submitting patches: mention get_reviewers.pl

[tournier.elie]

Nice,

Reviewed-by: Elie Tournier <tournier.elie at gmail.com>



2016-11-21 18:56 GMT+01:00 Emil Velikov <emil.l.velikov at gmail.com>:

> From: Emil Velikov <emil.velikov at collabora.com>
>
> Mention the script - why/how to use alongside a useful trick to make it
> work interactively (thanks Rob!).
>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> Based on top of the "git tips" from earlier.
> ---
>  docs/submittingpatches.html | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html
> index 7ada508..2f4be5d 100644
> --- a/docs/submittingpatches.html
> +++ b/docs/submittingpatches.html
> @@ -104,6 +104,19 @@ that should be documented with:
>      Reviewed-by: Joe Hacker <jhacker at foo.com>
>      Acked-by: Joe Hacker <jhacker at foo.com>
>  </pre>
> +<li>In order for your patch to reach the prospective reviewer
> easier/faster,
> +use the script scripts/get_reviewer.pl to get a list of individuals and
> include
> +them in the CC list.
> +<br>
> +Please use common sense and do <strong>not</strong> blindly add everyone.
> +<br>
> +<pre>
> +    $ scripts/get_reviewer.pl --help # to get the the help screen
> +    $ scripts/get_reviewer.pl -f src/egl/drivers/dri2/platform_android.c
> +    Rob Herring <robh at kernel.org> (reviewer:ANDROID EGL
> SUPPORT,added_lines:188/700=27%,removed_lines:58/283=20%)
> +    Tomasz Figa <tfiga at chromium.org> (reviewer:ANDROID EGL
> SUPPORT,authored:12/41=29%,added_lines:308/700=44%,
> removed_lines:115/283=41%)
> +    Emil Velikov <emil.l.velikov at gmail.com> (authored:13/41=32%,removed_
> lines:76/283=27%)
> +</pre>
>  </ul>
>
>
> @@ -335,6 +348,11 @@ commits before sending.
>      git send-email --subject-prefix="PATCH v4" HEAD~8
>      git send-email -v4 HEAD~8 # shorter version, 'inherited' from git
> format-patch
>  </pre>
> +<li> Configure git to use the get_reviewer.pl script interactively. Thus
> you
> +can avoid adding the world to the CC list.
> +<pre>
> +    git config sendemail.cccmd "./scripts/get_reviewer.pl -i"
> +</pre>
>  </ul>
>
>
> --
> 2.10.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161121/b0c1e39d/attachment-0001.html>