[Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

Jan Vesely jan.vesely at rutgers.edu
Fri Nov 25 00:15:04 UTC 2016


On Fri, 2016-11-25 at 00:00 +0000, Emil Velikov wrote:
> On 17 November 2016 at 17:27, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> 
> > Admittedly not a huge C++ expert, but what's wrong with having a
> > simple 5 line patch that adds the original code in a if guard ?
> > If then the LLVM <= 3.9 codepath is (somewhat) wrong, let's tackle
> > that separately.
> > 
> 
> Anyone ?

you might get a more complete answer from someone else (curro), but
given the volatility of LLVM's C++ interface and the range of versions
supported by mesa, all the ifdef mess is concentrated in the compat
layer (llvm/compat.h).
Vedran's v5 took that approach.

Jan

> 
> Emil
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161124/18ced089/attachment.sig>


More information about the mesa-dev mailing list