[Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

Francisco Jerez currojerez at riseup.net
Fri Nov 25 00:34:24 UTC 2016


Emil Velikov <emil.l.velikov at gmail.com> writes:

> On 17 November 2016 at 17:27, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>
>> Admittedly not a huge C++ expert, but what's wrong with having a
>> simple 5 line patch that adds the original code in a if guard ?
>> If then the LLVM <= 3.9 codepath is (somewhat) wrong, let's tackle
>> that separately.
>>
> Anyone ?
>
Hi Emil, that's basically what v5 of Vedran's patch does, but the macro
magic is factored into a separate function to keep the running code free
of compatibility clutter, otherwise his patch should behave identically
to the pre-existing code (prior to
8e430ff8b060b4e8e922bae24b3c57837da6ea77) on LLVM v3.9 and older.

> Emil
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161124/c3331af4/attachment.sig>


More information about the mesa-dev mailing list