[Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

Chad Versace chad at kiwitree.net
Tue Oct 4 21:31:50 UTC 2016

On Thu 29 Sep 2016, Emil Velikov wrote:
> On 28 September 2016 at 07:28, Chad Versace <chadversary at chromium.org> wrote:
> > Pre-patch, there were two code paths for parsing EGLSync attribute
> > lists: one path for old-style EGLint lists, used by eglCreateSyncKHR,
> > and another for new-style EGLAttrib lists, used by eglCreateSync (1.5)
> > and eglCreateSync64 (EGL_KHR_cl_event2).
> >
> Actually we might want to use the same helper instead of
> _eglConvertAttribsToInt for all entry points where the pre-1.5 entry
> point was using EGLint while the EGL 1.5 one uses EGLAttrib.

> In those cases we currently a) loose the upper bits (admittedly they
> aren't used afaics) and b) we'll error out if the user provides an
> empty/null list (not the most useful thing to do, but still).

I don't follow. What exactly are you proposing?

More information about the mesa-dev mailing list