[Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

[Chad Versace]

On Thu 29 Sep 2016, Emil Velikov wrote:
> On 28 September 2016 at 07:28, Chad Versace <chadversary at chromium.org> wrote:
> 
> > +   if (sizeof(int_list[0]) == sizeof(attrib_list[0])) {
> > +      attrib_list = (EGLAttrib *) int_list;
> > +   } else {
> > +      err = _eglConvertIntsToAttribs(int_list, &attrib_list);
> > +      if (err != EGL_SUCCESS)
> > +         RETURN_EGL_ERROR(disp, err, EGL_NO_SYNC);
> > +   }
> > +
> > +   sync = _eglCreateSync(disp, type, attrib_list, EGL_FALSE,
> >                           EGL_BAD_ATTRIBUTE);
> > +
> > +   if ((void *) int_list != (void *) attrib_list)

> Please use the same conditional as above - sizeof(int_list[0]) !=
> sizeof(attrib_list[0]).

Done.