[Mesa-dev] [PATCH v3] glsl: optimize copy_propagation_elements pass

Tapani Pälli tapani.palli at intel.com
Thu Oct 6 10:34:57 UTC 2016



On 10/06/2016 11:29 AM, Kenneth Graunke wrote:
> On Friday, September 30, 2016 8:12:12 AM PDT Ian Romanick wrote:
>> From: Tapani Pälli <tapani.palli at intel.com>
>>
>> Changes make copy_propagation_elements pass faster, reducing link
>> time spent in test case of bug 94477. Does not fix the actual issue
>> but brings down the total time. No regressions seen in CI.
>>
>> v2 (idr): Formatting / whitespace fixes.  Embed the acp_ref in the
>> acp_entry.
>>
>> v3 (idr): Delete unused copy constructor.  Use while(pop_head) instead
>> of foreach() { remove }.
>>
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
>
> This patch is:
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
>
> Assuming there are no changes in shader-db instruction counts
> before/after this change, feel free to push it.  Thanks for taking
> care of this!
>

Tested with shader-db shaders and Dota-2 ones, no changes in instruction 
counts; thanks for the review!

// Tapani



More information about the mesa-dev mailing list