[Mesa-dev] [PATCH] nv50/ir: fix wrong check when optimizing MAD to SHLADD

Ilia Mirkin imirkin at alum.mit.edu
Thu Oct 6 23:12:36 UTC 2016


Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

On Thu, Oct 6, 2016 at 7:11 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Checking if MAD is supported is definitely wrong, and it's
> more likely a typo I introduced few days ago which breaks
> NV50 because SHLADD is not supported there.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp
> index 1c71155..6efb29e 100644
> --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp
> +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp
> @@ -1030,7 +1030,7 @@ ConstantFolding::opnd(Instruction *i, ImmediateValue &imm0, int s)
>           i->op = OP_ADD;
>        } else
>        if (s == 1 && !imm0.isNegative() && imm0.isPow2() &&
> -          target->isOpSupported(i->op, i->dType)) {
> +          target->isOpSupported(OP_SHLADD, i->dType)) {
>           i->op = OP_SHLADD;
>           imm0.applyLog2();
>           i->setSrc(1, new_ImmediateValue(prog, imm0.reg.data.u32));
> --
> 2.10.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list