[Mesa-dev] [PATCH 2/5] amd/addrlib: hide private symbols via VISIBILITY_CXXFLAGS

[Bas Nieuwenhuizen]

On Wed, Oct 12, 2016 at 7:05 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> Private/internal symbols should never not be exported. Using the
> CXXFLAGS cuts ~300 exported symbols and ~23K from libvulkan_radeon.so.

Double negative? I think the message is much more consistent with
single negative. With that, patch 2-5 are

Acked-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  src/amd/Makefile.addrlib.am | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/amd/Makefile.addrlib.am b/src/amd/Makefile.addrlib.am
> index 434e692..64823fc 100644
> --- a/src/amd/Makefile.addrlib.am
> +++ b/src/amd/Makefile.addrlib.am
> @@ -30,6 +30,9 @@ addrlib_libamdgpu_addrlib_la_CPPFLAGS = \
>         -I$(srcdir)/addrlib/r800/chip \
>         -DBRAHMA_BUILD=1
>
> +addrlib_libamdgpu_addrlib_la_CXXFLAGS = \
> +       $(VISIBILITY_CXXFLAGS)
> +
>  noinst_LTLIBRARIES += $(ADDRLIB_LIBS)
>
>  addrlib_libamdgpu_addrlib_la_SOURCES = $(ADDRLIB_FILES)
> --
> 2.10.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev