[Mesa-dev] [PATCH 2/5] amd/addrlib: hide private symbols via VISIBILITY_CXXFLAGS

[Emil Velikov]

On 12 October 2016 at 20:28, Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl> wrote:
> On Wed, Oct 12, 2016 at 7:05 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>>
>> Private/internal symbols should never not be exported. Using the
>> CXXFLAGS cuts ~300 exported symbols and ~23K from libvulkan_radeon.so.
>
> Double negative? I think the message is much more consistent with
> single negative. With that, patch 2-5 are
>
> Acked-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
>
Hmm nicely spotted. Guess there's no need to explain that double
"negatives" behave differently in other languages ;-)

Thanks
Emil