[Mesa-dev] [PATCH] radv: allow cmask transitions without fast clear

Edward O'Callaghan funfunctor at folklore1984.net
Fri Oct 21 06:46:08 UTC 2016


Acked-by: Edward O'Callaghan <funfunctor at folklore1984.net>

On 10/21/2016 10:36 AM, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> This fixes
> dEQP-VK.pipeline.multisample.sampled_image*
> 
> These all render to multisampled image, and then
> sample from it, so we must transition it correctly,
> since we have a cmask and fmask this will cause
> the correct transition.
> 
> Cc: "13.0" <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index 3f1a6f4..690c739 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -2163,9 +2163,6 @@ static void radv_handle_cmask_image_transition(struct radv_cmd_buffer *cmd_buffe
>  			radv_initialise_cmask(cmd_buffer, image, 0xffffffffu);
>  	} else if (radv_layout_has_cmask(image, src_layout) &&
>  		   !radv_layout_has_cmask(image, dst_layout)) {
> -
> -		if (!cmd_buffer->device->allow_fast_clears)
> -			return;
>  		radv_fast_clear_flush_image_inplace(cmd_buffer, image);
>  	}
>  }
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161021/3b234ccb/attachment.sig>


More information about the mesa-dev mailing list