[Mesa-dev] [PATCH] radv: allow cmask transitions without fast clear

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Fri Oct 21 18:31:26 UTC 2016


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Fri, Oct 21, 2016 at 1:36 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> This fixes
> dEQP-VK.pipeline.multisample.sampled_image*
>
> These all render to multisampled image, and then
> sample from it, so we must transition it correctly,
> since we have a cmask and fmask this will cause
> the correct transition.
>
> Cc: "13.0" <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index 3f1a6f4..690c739 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -2163,9 +2163,6 @@ static void radv_handle_cmask_image_transition(struct radv_cmd_buffer *cmd_buffe
>                         radv_initialise_cmask(cmd_buffer, image, 0xffffffffu);
>         } else if (radv_layout_has_cmask(image, src_layout) &&
>                    !radv_layout_has_cmask(image, dst_layout)) {
> -
> -               if (!cmd_buffer->device->allow_fast_clears)
> -                       return;
>                 radv_fast_clear_flush_image_inplace(cmd_buffer, image);
>         }
>  }
> --
> 2.5.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list