[Mesa-dev] [Bug 98245] GLES3.1 link negative dEQP "expected linking to fail, but passed."

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=98245

--- Comment #2 from Iago Toral <itoral at igalia.com> ---
(In reply to Iago Toral from comment #1)
> These seem to be two different issues so I think it is probably best to
> create two different bug reports.
> 
> I have sent a patch for review that fixes the first one:
> https://lists.freedesktop.org/archives/mesa-dev/2016-October/132896.html

This patch is now in master:

commit 537dce06ec8e0fa4becd42d5e4b3d07cf722387f
Author: Iago Toral Quiroga <itoral at igalia.com>
Date:   Fri Oct 21 13:15:41 2016 +0200

    glsl: add matrix layout information to interface block types

    So far we have been checking that interface block definitions had matching
    matrix layouts by comparing the definitions of their fields, however, this
    does not cover the case where the interface blocks are defined with
    mismatching matrix layouts but don't define any field with a matrix type.
    In this case Mesa will not fail to link because none of the fields will
    inherit the mismatching layout qualifier.

    This patch fixes the problem in the same way we fixed it for packing layout
    information: we add the the layout information to the interface type and
then
    we check it matches during the uniform block linking process.

    v2: Fix unit tests so they pass the new parameter to
        glsl_type::get_interface_instance()

    Fixes:
   
dEQP-GLES31.functional.shaders.linkage.uniform.block.layout_qualifier_mismatch_3

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98245
    Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com> (v1)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161025/c058fb36/attachment.html>