[Mesa-dev] [PATCH 05/26] i965: Set fast clear state only once in render cycle

[Jason Ekstrand]

On Tue, Oct 11, 2016 at 12:26 PM, Topi Pohjolainen <
topi.pohjolainen at gmail.com> wrote:

> Blorp operations used to set it before rendering and again just
> after.
>

I think this patche is definitely an improvement.  2-5 are

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

However, at some point I think we want to revamp our tracking.  We really
have 3 fast clear states:

 1) Resolved (main surface is 100% acurate)
 2) Unresolved (need data from both clear color and CCS)
 3) Partially resolved (only need CCS, clear color doesn't matter)

Given the fact that we don't actually use fast clears when CCS is enabled,
we never actually hit (2).  But... I happen to know you're working on fast
clears so I'm sure you'll get to it. :-)


> Calling intel_miptree_used_for_rendering() for gen6 and earlier
> as well as for hiz is a no-op. It only deals with color buffers
> supporting fast clear/lossless compression.
>
> Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_blorp.c            | 24
> ++++--------------------
>  src/mesa/drivers/dri/i965/brw_draw.c             |  5 +----
>  src/mesa/drivers/dri/i965/brw_wm_surface_state.c |  3 ---
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.h    |  6 ++++--
>  4 files changed, 9 insertions(+), 29 deletions(-)
>

[snip...]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161028/b37aef3d/attachment.html>