[Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

[Gurchetan Singh]

Why would PTHREAD_LIBS ever be set at all?  Isn't the reason for the
proposed cleanup is we've been passing -pthread as a lib instead of as a
linker flag?

On Fri, Oct 28, 2016 at 5:23 PM, Emil Velikov <emil.l.velikov at gmail.com>
wrote:

> On Friday, 28 October 2016, Gurchetan Singh <gurchetansingh at chromium.org>
> wrote:
>
>> I'm confused what the desired cleanup is.  Do you want
>>
>> 1) PKG_CHECK_MODULES(PTHREAD, [pthread]) in configure.ac
>> or
>> 2) All references to PTHREAD_LIBS in the configure.ac and the makefiles
>> to be removed.  In the cases where this breaks the build, PTHREAD_CFLAGS
>> should be added to the AM_LDFLAGS.
>>
>>
> Almost #2, but not quite. Drop the configure hunk (revert Matt's commit)
> and add PTHREAD_CFLAGS/LIBS pairs to the respective cflags/libs where
> linking fails.
>
> Thanks
> Emil
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161031/cee38e72/attachment.html>