[Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform
Emil Velikov
emil.l.velikov at gmail.com
Mon Oct 31 16:49:52 UTC 2016
On 31 October 2016 at 16:27, Gurchetan Singh
<gurchetansingh at chromium.org> wrote:
> Why would PTHREAD_LIBS ever be set at all? Isn't the reason for the
> proposed cleanup is we've been passing -pthread as a lib instead of as a
> linker flag?
>
-pthread is the most common scenario, but there are others - if bored
skim through m4/ax_pthread.m4 but be warned !
The gist is that, like pretty much everything else - the user just
adds the CFLAGS/LIBS pair and doesn't need to worry about any of the
specifics.
The thread you linked works around people forgetting to use the pair.
Which will work in some places but not others.
That said, if things get too nasty - just sent the lot that you're
tracked, alongside the original patch. Just add a comment in the
latter "XXX/TODO/other: we'd want to correctly set the PTHREAD....
and drop the following workaround". Or anything else that you think
makes things clearer.
Thanks
Emil
More information about the mesa-dev
mailing list