[Mesa-dev] [PATCH 03/12] isl/gen8+: Allow 3D auxiliary surfaces

[Jason Ekstrand]

On Wed, Aug 31, 2016 at 8:17 AM, Topi Pohjolainen <
topi.pohjolainen at intel.com> wrote:

> Otherwise once mcs buffer gets allocated without delay for
> lossless compression (same as we do for msaa), assert starts
> to fire in piglit case: tex3d. The test uses depth of one
> which is in fact supported even now.
>
> Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> ---
>  src/intel/isl/isl.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
> index c4989dd..b5c4a8c 100644
> --- a/src/intel/isl/isl.c
> +++ b/src/intel/isl/isl.c
> @@ -1328,7 +1328,12 @@ isl_surf_get_ccs_surf(const struct isl_device *dev,
>     assert(surf->samples == 1 && surf->msaa_layout ==
> ISL_MSAA_LAYOUT_NONE);
>     assert(ISL_DEV_GEN(dev) >= 7);
>
> -   assert(surf->dim == ISL_SURF_DIM_2D);
> +   if (ISL_DEV_GEN(dev) < 8) {
> +      assert(surf->dim == ISL_SURF_DIM_2D);
> +   } else {
> +      assert(surf->dim == ISL_SURF_DIM_2D || surf->dim ==
> ISL_SURF_DIM_3D);
> +   }
>

What about 1D?  Maybe we just never try to allocate 1D Y-tiled.  Also, if
it's 3D, should we assert depth == 1?


> +
>     assert(surf->logical_level0_px.depth == 1);
>
>     /* TODO: More conditions where it can fail. */
> --
> 2.5.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160831/0e95974a/attachment.html>