[Mesa-dev] [PATCH 03/12] isl/gen8+: Allow 3D auxiliary surfaces

[Pohjolainen, Topi]

On Wed, Aug 31, 2016 at 05:41:24PM -0700, Jason Ekstrand wrote:
>    On Wed, Aug 31, 2016 at 8:17 AM, Topi Pohjolainen
>    <[1]topi.pohjolainen at intel.com> wrote:
> 
>      Otherwise once mcs buffer gets allocated without delay for
>      lossless compression (same as we do for msaa), assert starts
>      to fire in piglit case: tex3d. The test uses depth of one
>      which is in fact supported even now.
>      Signed-off-by: Topi Pohjolainen <[2]topi.pohjolainen at intel.com>
>      ---
>      Â src/intel/isl/isl.c | 7 ++++++-
>      Â 1 file changed, 6 insertions(+), 1 deletion(-)
>      diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
>      index c4989dd..b5c4a8c 100644
>      --- a/src/intel/isl/isl.c
>      +++ b/src/intel/isl/isl.c
>      @@ -1328,7 +1328,12 @@ isl_surf_get_ccs_surf(const struct isl_device
>      *dev,
>      Â  Â  assert(surf->samples == 1 && surf->msaa_layout ==
>      ISL_MSAA_LAYOUT_NONE);
>      Â  Â  assert(ISL_DEV_GEN(dev) >= 7);
>      -Â  Â assert(surf->dim == ISL_SURF_DIM_2D);
>      +Â  Â if (ISL_DEV_GEN(dev) < 8) {
>      +Â  Â  Â  assert(surf->dim == ISL_SURF_DIM_2D);
>      +Â  Â } else {
>      +Â  Â  Â  assert(surf->dim == ISL_SURF_DIM_2D || surf->dim ==
>      ISL_SURF_DIM_3D);
>      +Â  Â }
> 
>    What about 1D?  Maybe we just never try to allocate 1D Y-tiled.Â

I guess so, I can't think of any restrictions why compression or fast clear
itself wouldn't be supported.

>    Also, if it's 3D, should we assert depth == 1?

Check for the depth is just below.

>    Â
> 
>      +
>      Â  Â  assert(surf->logical_level0_px.depth == 1);
>      Â  Â  /* TODO: More conditions where it can fail. */
>      --
>      2.5.5
>      _______________________________________________
>      mesa-dev mailing list
>      [3]mesa-dev at lists.freedesktop.org
>      [4]https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> References
> 
>    1. mailto:topi.pohjolainen at intel.com
>    2. mailto:topi.pohjolainen at intel.com
>    3. mailto:mesa-dev at lists.freedesktop.org
>    4. https://lists.freedesktop.org/mailman/listinfo/mesa-dev

> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev