[Mesa-dev] [PATCH v2] egl: return corresponding offset of EGLImage instead of 0.

Weng Chuanbo chuanbo.weng at gmail.com
Tue Sep 6 03:03:47 UTC 2016


Got it. Thanks for your patient explanation!

2016-09-06 1:14 GMT+08:00 Emil Velikov <emil.l.velikov at gmail.com>:

> On 5 September 2016 at 17:21, Weng Chuanbo <chuanbo.weng at gmail.com> wrote:
>
> > [****Chuanbo****] Could you explain " we want these NULL checks split out
> > and ported to older loader " more detailed?
> >
> > And what's older loaders? What's newer dri modules?
> >
> > From my understanding, the only path in mesa code invokes mapImage is
> > gbm_dri_bo_map. So if apply my patch code above, no NULL deref will
> happen.
> >
> For this particular exercise we can say that there are three loaders -
> src/{gbm,glx,egl}, the interface is in include/ and everything else
> can be considered* as dri module/drivers.
>
> So here you want to split out the null checks into a separate patches,
> which precede the functional (EGLimage) change. This way the former
> can be applied (as they are bugfixes) for older versions of mesa.
>
> -Emil
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160906/1f6d22cb/attachment.html>


More information about the mesa-dev mailing list