[Mesa-dev] [PATCH] android: fix a build issue with libmesa_st_mesa_32

[Emil Velikov]

On 7 September 2016 at 11:01, Mauro Rossi <issor.oruam at gmail.com> wrote:
> Hi Tapani,
>
> does moving the declaration of the dependency to
> src/mesa/drivers/dri/i965/Android.mk also work?
> Mauro
>
> LOCAL_WHOLE_STATIC_LIBRARIES := \
> $(MESA_DRI_WHOLE_STATIC_LIBRARIES) \
> + libmesa_genxml \
> libmesa_isl
>
>
Mauro, it's very unlikely that this will work. Afaict the static lib
is required to pull the generated XML headers into the generated C
file.

Adding libmesa_genxml to LOCAL_WHOLE_STATIC_LIBRARIES will move the
dependency (and thus generation) of the said headers to the (final)
link stage. At which point all the files are (should be) compiled.

Tapani, please send a patch with your fix with a line worth of commit
message (feel free to copy mine you want) ? Feel free to add
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Tapani, can I interest you in __DRI_IMAGE_VERSION 12 (map/unmap image)
for i965 ? With the i915 kernel module (almost) atomic it will be a
great to move away from drm_gralloc to gbm_gralloc.
Plus it should make the following patch/workaround[1] obsolete.

Thanks
Emil

[1] https://chromium.googlesource.com/chromiumos/third_party/mesa/+/c9d73a323943af5e20457fd4bf1f811a97f33a9e