[Mesa-dev] [PATCH] android: fix a build issue with libmesa_st_mesa_32

[Mauro Rossi]

2016-09-07 12:56 GMT+02:00 Emil Velikov <emil.l.velikov at gmail.com>:

> On 7 September 2016 at 11:01, Mauro Rossi <issor.oruam at gmail.com> wrote:
> > Hi Tapani,
> >
> > does moving the declaration of the dependency to
> > src/mesa/drivers/dri/i965/Android.mk also work?
> > Mauro
> >
> > LOCAL_WHOLE_STATIC_LIBRARIES := \
> > $(MESA_DRI_WHOLE_STATIC_LIBRARIES) \
> > + libmesa_genxml \
> > libmesa_isl
> >
> >
> Mauro, it's very unlikely that this will work. Afaict the static lib
> is required to pull the generated XML headers into the generated C
> file.
>
> Adding libmesa_genxml to LOCAL_WHOLE_STATIC_LIBRARIES will move the
> dependency (and thus generation) of the said headers to the (final)
> link stage. At which point all the files are (should be) compiled.
>
> Tapani, please send a patch with your fix with a line worth of commit
> message (feel free to copy mine you want) ? Feel free to add
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
>

Just a final check, minor aesthetics,

should the libmesa_genxml static library dependency be declared in
src/mesa/drivers/dri/i965/Android.mk
instead of doing it src/mesa/drivers/dri/i965/Android.gen.mk, which sole
purpose is to generate sources?

M.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160907/6af93f3b/attachment.html>