[Mesa-dev] [PATCH 01/15] glsl: Fix cut-and-paste bug in hierarchical visitor ir_expression::accept

[Kenneth Graunke]

On Thursday, September 15, 2016 3:12:34 PM PDT Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> At this point in the code, s must be visit_continue.  If the child
> returned visit_stop, visit_stop is the only correct thing to return.
> 
> Found by inspection.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Cc: mesa-stable at lists.freedesktop.org
> ---
>  src/compiler/glsl/ir_hv_accept.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/compiler/glsl/ir_hv_accept.cpp b/src/compiler/glsl/ir_hv_accept.cpp
> index 213992a..5cc6a34 100644
> --- a/src/compiler/glsl/ir_hv_accept.cpp
> +++ b/src/compiler/glsl/ir_hv_accept.cpp
> @@ -147,7 +147,7 @@ ir_expression::accept(ir_hierarchical_visitor *v)
>  	 goto done;
>  
>        case visit_stop:
> -	 return s;
> +	 return visit_stop;
>        }
>     }
>  
> 

Patches 1-2, 7-8, and 13 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

You may as well land those ahead of the rest of the series.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160918/f5e60619/attachment.sig>