[Mesa-dev] [PATCH 88/88] i965: handle 32bit and 64bit version of shader cache objects

[Eric Anholt]

Timothy Arceri <timothy.arceri at collabora.com> writes:

> On Sun, 2016-09-25 at 19:51 -0700, Kenneth Graunke wrote:
>> On Saturday, September 24, 2016 3:26:09 PM PDT Timothy Arceri wrote:
>> > 
>> > Pointers will have different lengths so we simple create a
>> > different
>> > sha1 for each platform.
>> 
>> I don't understand...you're putting pointers in the blob?  How can
>> that
>> work?  You obviously can't reload things from the cache as actual
>> pointers, so you've got to be doing some kind of remapping from a
>> "pointer" in the blob to a real pointer.
>> 
>> At that point, can't you just make the blob always use a uint64_t for
>> pointers, and just pad with zeroes on 32-bit systems?  Then we could
>> use the same copy for both...
>
> We probably could but we are currently using intptr_t for
> storing/restoring pointers and ptrdiff_t during remapping as we
> probably should be. Thoughts?

Use consistent uint64_t on disk and remap to 32/64 on the way back in,
imo.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160928/88b11db9/attachment.sig>