[Mesa-dev] [PATCH] i915/i965: remove commented out warning

Ian Romanick idr at freedesktop.org
Fri Sep 30 15:06:11 UTC 2016


Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 09/29/2016 11:37 PM, Timothy Arceri wrote:
> The warning was also the wrong location, it should have been
> in the else.
> ---
>  src/mesa/drivers/dri/i915/intel_fbo.h | 4 +---
>  src/mesa/drivers/dri/i965/intel_fbo.h | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i915/intel_fbo.h b/src/mesa/drivers/dri/i915/intel_fbo.h
> index 114dd68..769dab8 100644
> --- a/src/mesa/drivers/dri/i915/intel_fbo.h
> +++ b/src/mesa/drivers/dri/i915/intel_fbo.h
> @@ -89,10 +89,8 @@ static inline struct intel_renderbuffer *
>  intel_renderbuffer(struct gl_renderbuffer *rb)
>  {
>     struct intel_renderbuffer *irb = (struct intel_renderbuffer *) rb;
> -   if (irb && irb->Base.Base.ClassID == INTEL_RB_CLASS) {
> -      /*_mesa_warning(NULL, "Returning non-intel Rb\n");*/
> +   if (irb && irb->Base.Base.ClassID == INTEL_RB_CLASS)
>        return irb;
> -   }
>     else
>        return NULL;
>  }
> diff --git a/src/mesa/drivers/dri/i965/intel_fbo.h b/src/mesa/drivers/dri/i965/intel_fbo.h
> index 89894cd..e6f6156 100644
> --- a/src/mesa/drivers/dri/i965/intel_fbo.h
> +++ b/src/mesa/drivers/dri/i965/intel_fbo.h
> @@ -130,10 +130,8 @@ static inline struct intel_renderbuffer *
>  intel_renderbuffer(struct gl_renderbuffer *rb)
>  {
>     struct intel_renderbuffer *irb = (struct intel_renderbuffer *) rb;
> -   if (irb && irb->Base.Base.ClassID == INTEL_RB_CLASS) {
> -      /*_mesa_warning(NULL, "Returning non-intel Rb\n");*/
> +   if (irb && irb->Base.Base.ClassID == INTEL_RB_CLASS)
>        return irb;
> -   }
>     else
>        return NULL;
>  }
> 



More information about the mesa-dev mailing list