[Mesa-dev] [PATCH 1/3] radeonsi: clean up 'radeon_bld' references

Marek Olšák maraeo at gmail.com
Mon Apr 3 09:08:18 UTC 2017


On Mon, Apr 3, 2017 at 11:00 AM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> On 03.04.2017 02:01, Marek Olšák wrote:
>>
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> ---
>>  src/gallium/drivers/radeonsi/si_shader.c | 108
>> ++++++++++++++-----------------
>>  1 file changed, 48 insertions(+), 60 deletions(-)
>>
>> diff --git a/src/gallium/drivers/radeonsi/si_shader.c
>> b/src/gallium/drivers/radeonsi/si_shader.c
>> index 3876010..2da00f9 100644
>> --- a/src/gallium/drivers/radeonsi/si_shader.c
>> +++ b/src/gallium/drivers/radeonsi/si_shader.c
>> @@ -293,37 +293,35 @@ get_tcs_out_current_patch_data_offset(struct
>> si_shader_context *ctx)
>>         LLVMValueRef patch_stride = get_tcs_out_patch_stride(ctx);
>>         LLVMValueRef rel_patch_id = get_rel_patch_id(ctx);
>>
>>         return LLVMBuildAdd(gallivm->builder, patch0_patch_data_offset,
>>                             LLVMBuildMul(gallivm->builder, patch_stride,
>>                                          rel_patch_id, ""),
>>                             "");
>>  }
>>
>>  static LLVMValueRef get_instance_index_for_fetch(
>> -       struct si_shader_context *radeon_bld,
>> +       struct si_shader_context *ctx,
>>         unsigned param_start_instance, unsigned divisor)
>>  {
>> -       struct si_shader_context *ctx =
>> -               si_shader_context(&radeon_bld->bld_base);
>> -       struct gallivm_state *gallivm = radeon_bld->bld_base.base.gallivm;
>> +       struct gallivm_state *gallivm = ctx->bld_base.base.gallivm;
>
>
> This could just be &ctx->gallivm. Apart from that, the series is

That will be a separate patch.

>
> Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

Thanks.

Marek


More information about the mesa-dev mailing list