[Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

Marek Olšák maraeo at gmail.com
Wed Apr 12 15:53:44 UTC 2017


On Wed, Apr 12, 2017 at 4:44 PM, Markus Trippelsdorf
<markus at trippelsdorf.de> wrote:
> On 2017.04.10 at 22:48 +0200, Marek Olšák wrote:
>> Pushed the series, thanks!
>>
>> Marek
>>
>> On Mon, Apr 10, 2017 at 10:04 PM, Constantine Kharlamov
>> <Hi-Angel at yandex.ru> wrote:
>> > The idea is taken from radeonsi. The code mostly was already checking for null
>> > pixel shader, so little checks had to be added.
>> >
>> > Interestingly, acc. to testing with GTAⅣ, though binding of null shader happens
>> > a lot at the start (then just stops), but draw_vbo() never actually sees null
>> > ps.
>> >
>> > v2: added a check I missed because of a macros using a prefix to choose
>> > a shader.
>
> This commit causes ring 0 stalls on r600:
> https://bugs.freedesktop.org/show_bug.cgi?id=100663

Thanks, I reverted the commit.

Marek


More information about the mesa-dev mailing list