[Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

Markus Trippelsdorf markus at trippelsdorf.de
Wed Apr 12 20:03:22 UTC 2017


On 2017.04.12 at 20:45 +0100, Emil Velikov wrote:
> On 12 April 2017 at 20:34, Constantine Kharlamov <Hi-Angel at yandex.ru> wrote:
> 
> >> I suspect this breaks because r600 more often fails to
> >> compile some shaders,
> >> and the hw requires a fragment shader and we use the empty one as a
> >> fallback in that case.
> >
> > Ok, that wasn't obvious, I running the system with the patchset on HD5730, including
> > piglit testing — so far is fine.
> >
> If in doubt ask the bug reporter(s) to test a patch on their machines.

Well, the question is why bother with this legacy code at all?
I would expect a much more conservative approach. Except for essential
patches to keep the hardware running, everything else should be
rejected. Nobody is expecting new features for this ancient hardware
anyway.

-- 
Markus


More information about the mesa-dev mailing list