[Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

[Marek Olšák]

On Apr 13, 2017 3:34 AM, "Markus Trippelsdorf" <markus at trippelsdorf.de>
wrote:

On 2017.04.12 at 20:45 +0100, Emil Velikov wrote:
> On 12 April 2017 at 20:34, Constantine Kharlamov <Hi-Angel at yandex.ru>
wrote:
>
> >> I suspect this breaks because r600 more often fails to
> >> compile some shaders,
> >> and the hw requires a fragment shader and we use the empty one as a
> >> fallback in that case.
> >
> > Ok, that wasn't obvious, I running the system with the patchset on
HD5730, including
> > piglit testing — so far is fine.
> >
> If in doubt ask the bug reporter(s) to test a patch on their machines.

Well, the question is why bother with this legacy code at all?
I would expect a much more conservative approach. Except for essential
patches to keep the hardware running, everything else should be
rejected. Nobody is expecting new features for this ancient hardware
anyway.


As long as the new code is tested, there is no reason for not accepting it.
It's how open source works.

Marek



--
Markus
_______________________________________________
mesa-dev mailing list
mesa-dev at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170413/83008871/attachment.html>