[Mesa-dev] [PATCH 2/2] radeonsi: disable primitive restart for non-strip prims based on app list

[Kenneth Graunke]

On Monday, April 24, 2017 6:22:41 AM PDT Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> ---
>  src/gallium/drivers/radeonsi/si_pipe.c       | 20 +++++++++++++
>  src/gallium/drivers/radeonsi/si_pipe.h       |  1 +
>  src/gallium/drivers/radeonsi/si_state_draw.c | 45 ++++++++++++++++++++--------
>  3 files changed, 54 insertions(+), 12 deletions(-)
> 
> diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c
> index 1a83564..53a8201 100644
> --- a/src/gallium/drivers/radeonsi/si_pipe.c
> +++ b/src/gallium/drivers/radeonsi/si_pipe.c
> @@ -29,20 +29,29 @@
>  #include "radeon/radeon_uvd.h"
>  #include "util/u_memory.h"
>  #include "util/u_suballoc.h"
>  #include "util/u_tests.h"
>  #include "vl/vl_decoder.h"
>  #include "../ddebug/dd_util.h"
>  
>  #define SI_LLVM_DEFAULT_FEATURES \
>  	"+DumpCode,+vgpr-spilling,-fp32-denormals,-xnack"
>  
> +/* DX10/11 apply primitive restart to strip primitive types only. */
> +static const char *apps_with_prim_restart_dx_behavior[] = {
> +	"DeusExMD",
> +	"DirtRally",
> +	"HitmanPro",
> +	"MadMax",
> +	"TotalWarhammer",
> +};
> +

Hi Marek,

You seem to be adding driver workarounds for an incomplete list of Feral
Interactive's titles.  Presumably, if you're going to go this route, you
may need to add more of them.  Or, perhaps this is something they can
fix in their translator layer, so they only enable it when they want it?

I've copied Marc and Alex from Feral in case they want to weigh in.

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170424/5aa82dca/attachment.sig>