[Mesa-dev] [PATCH 1/2] egl_dri2: Add support for Tizen

Emil Velikov emil.l.velikov at gmail.com
Tue Apr 25 15:03:54 UTC 2017


Hi Gwan-gyeong,

On 12 April 2017 at 01:48, Mun Gwan-gyeong <elongbug at gmail.com> wrote:
> From: "Mun, Gwan-gyeong" <kk.moon at samsung.com>

> ---
>  src/egl/Makefile.am                   |    7 +
>  src/egl/drivers/dri2/egl_dri2.c       |   11 +
>  src/egl/drivers/dri2/egl_dri2.h       |   36 +
>  src/egl/drivers/dri2/platform_tizen.c | 1543 +++++++++++++++++++++++++++++++++

>From a quick look most of this code is copy/pasted from platform_wayland.c.

At the same time, large portions of the android, gbm and wayland (not
sure about x11) platforms are almost identical.
With the biggest differences due to feature X implemented on platform
A, but not on platform B.

Before we proceed with adding new platforms we _really_ want to
refactor and de-duplicate the existing code.
Can you give that a stab - the common code can go in egl_dri2.c?

Thanks
Emil


More information about the mesa-dev mailing list