[Mesa-dev] [PATCH 1/2] egl_dri2: Add support for Tizen

Daniel Stone daniel at fooishbar.org
Tue Apr 25 15:58:37 UTC 2017


Hi,

On 25 April 2017 at 17:03, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> From a quick look most of this code is copy/pasted from platform_wayland.c.
>
> At the same time, large portions of the android, gbm and wayland (not
> sure about x11) platforms are almost identical.
> With the biggest differences due to feature X implemented on platform
> A, but not on platform B.
>
> Before we proceed with adding new platforms we _really_ want to
> refactor and de-duplicate the existing code.
> Can you give that a stab - the common code can go in egl_dri2.c?

There are also parts which are clearly not relevant, e.g. checks for
the surface being a pbuffer, when the surface-creation code fails if a
pbuffer surface is requested.

Cheers,
Daniel


More information about the mesa-dev mailing list