[Mesa-dev] [Bug 98132] #version 300 es compute shaders should not be possible

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=98132

Tapani Pälli <lemody at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Tapani Pälli <lemody at gmail.com> ---
commit 5bc222ebafddd14f2329f5096287b51d798a6431
Author: Jose Maria Casanova Crespo <jmcasanova at igalia.com>
Date:   Fri Feb 10 14:25:27 2017 +0100

    glsl: non-last member unsized array on SSBO must fail compilation on GLSL
ES 3.1

    From GLSL ES 3.10 spec, section 4.1.9 "Arrays":

    "If an array is declared as the last member of a shader storage block
     and the size is not specified at compile-time, it is sized at run-time.
     In all other cases, arrays are sized only at compile-time."

    In desktop GLSL it is allowed to have unsized-arrays that are
    not last, as long as we can determine that they are implicitly
    sized, which is detected at link-time.

    With this patch Mesa reports a compilation error as glslang does with
    the following shader:

    buffer SSBO { vec4 data[]; vec4 moreData;};
    void main (void)
    {
    }

    Fixes:
   
dEQP-GLES31.functional.debug.negative_coverage.log.shader.compile_compute_shader
   
dEQP-GLES31.functional.debug.negative_coverage.callbacks.shader.compile_compute_shader
   
dEQP-GLES31.functional.debug.negative_coverage.get_error.shader.compile_compute_shader

    Cc: "17.0" <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Jose Maria Casanova Crespo <jmcasanova at igalia.com>
    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170427/db2c5db4/attachment-0001.html>