[Mesa-dev] [PATCH] intel/genxml: Fix gen10 BLEND_STATE variable length packing

[Anuj Phogat]

On Fri, Aug 4, 2017 at 3:21 PM, Scott D Phillips <scott.d.phillips at intel.com
> wrote:

> BLEND_STATE packing was modified to be variable-length in:
>
>  9670124e31 genxml: Make BLEND_STATE command support variable length array.
>
> The initial gen10.xml still had the old, fixed-length style
> definition for BLEND_STATE. So gen10_upload_blend_state would
> overwrite the packed BLEND_STATE_ENTRYs with its own fixed array
> of all-zero entries when packing BLEND_STATE. This caused
> BLEND_STATE upload to not work at all.
>
> Fixes: aa416f515a ("i965/genxml: Add gen10.xml")
> ---
>  src/intel/genxml/gen10.xml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/genxml/gen10.xml b/src/intel/genxml/gen10.xml
> index 23c2adb995..a7ae49ae65 100644
> --- a/src/intel/genxml/gen10.xml
> +++ b/src/intel/genxml/gen10.xml
> @@ -554,7 +554,7 @@
>      <field name="Write Disable Blue" start="0" end="0" type="bool"/>
>    </struct>
>
> -  <struct name="BLEND_STATE" length="17">
> +  <struct name="BLEND_STATE" length="1">
>      <field name="Alpha To Coverage Enable" start="31" end="31"
> type="bool"/>
>      <field name="Independent Alpha Blend Enable" start="30" end="30"
> type="bool"/>
>      <field name="Alpha To One Enable" start="29" end="29" type="bool"/>
> @@ -564,7 +564,7 @@
>      <field name="Color Dither Enable" start="23" end="23" type="bool"/>
>      <field name="X Dither Offset" start="21" end="22" type="uint"/>
>      <field name="Y Dither Offset" start="19" end="20" type="uint"/>
> -    <group count="8" start="32" size="64">
> +    <group count="0" start="32" size="64">
>        <field name="Entry" start="0" end="63" type="BLEND_STATE_ENTRY"/>
>      </group>
>    </struct>
> --
> 2.11.0
>
> ​LGTM. I think it'll fix many failing piglit tests on CNL. Thanks.

​
Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170807/55582999/attachment.html>