[Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

[Emil Velikov]

On 11 August 2017 at 12:31, Tapani Pälli <tapani.palli at intel.com> wrote:
> On 08/11/2017 02:23 PM, Grazvydas Ignotas wrote:
>>
>> On Fri, Aug 11, 2017 at 8:52 AM, Kenneth Graunke <kenneth at whitecape.org>
>> wrote:
>>>
>>> This should hopefully fix build issues on 32-bit Android-x86.
>>>
>>> Cc: Mauro Rossi <issor.oruam at gmail.com>
>>> Cc: Tapani Pälli <tapani.palli at intel.com>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102050
>>> ---
>>>   src/mesa/drivers/dri/i965/intel_buffer_objects.c | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> Mauro, hopefully this helps?
>>>
>>> diff --git a/src/mesa/drivers/dri/i965/intel_buffer_objects.c
>>> b/src/mesa/drivers/dri/i965/intel_buffer_objects.c
>>> index ee591168283..9afd98edb87 100644
>>> --- a/src/mesa/drivers/dri/i965/intel_buffer_objects.c
>>> +++ b/src/mesa/drivers/dri/i965/intel_buffer_objects.c
>>> @@ -342,6 +342,7 @@ brw_get_buffer_subdata(struct gl_context *ctx,
>>>
>>>      unsigned int map_flags = MAP_READ;
>>>      mem_copy_fn memcpy_fn = memcpy;
>>> +#ifdef USE_SSE4_1
>>
>>
>> I don't think anything is defining USE_SSE4_1 in mesa, so you are
>> disabling this code for everyone.
>
>
> Right .. it should be USE_SSE41, r-b with that
>
Hmm you've beat me to it - yes USE_SSE41 it is. With that:
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Fwiw: The construct can be seen elsewhere - might want to move to a
helper at some later stage.

-Emil